25 Mar
2019
25 Mar
'19
2:51 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32029 )
Change subject: libpayload: strtoull: Fix edge case bug with *endptr ......................................................................
Patch Set 2: Code-Review+2
"0x" seems to be the opposite case and needs the bail-out, afaics
Oh, you mean if there's only "0x" without another valid digit after it? I think in that case it's actually supposed to parse the '0' and set *endptr to the 'x'... at least that seems to be what glibc is doing. I can fix that too.
Right. I only saw that you are changing this case too and overlooked that it was broken anyway. Thanks for fixing it!
--
To view, visit https://review.coreboot.org/c/coreboot/+/32029
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idddd74e18e410a9d0b6dce9512ca0412b9e2333c
Gerrit-Change-Number: 32029
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Mar 2019 21:51:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment