build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31944 )
Change subject: G505S AtomBIOS ROMs: known good binaries with a script to check their SHA256 ......................................................................
Patch Set 1:
(57 comments)
https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh File check_atombios_roms.sh:
https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh@8 PS1, Line 8: echo "SHA256 checksums are correct. Use these AtomBIOS ROMs at your coreboot .config :" line over 80 characters
https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh@9 PS1, Line 9: echo "*990b.rom = iGPU HD-8650G | *6663.rom = dGPU HD-8570M / *6665.rom = dGPU R5-M230" line over 80 characters
https://review.coreboot.org/#/c/31944/1/check_atombios_roms.sh@12 PS1, Line 12: echo "! MISMATCH ! See ./sha256sums_atombios_my.txt and ./sha256sums_atombios_correct.txt" line over 80 characters
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt File pci1002,6663.rom.txt:
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@10 PS1, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a500 00c6 cc20 .>x...X@,...... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@19 PS1, Line 19: 00000120: 6368 6c61 6e64 2020 2020 2020 2020 2020 chland trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@20 PS1, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@332 PS1, Line 332: 000014b0: 2366 25ff ff00 0066 3bc8 7321 32db eb20 #f%....f;.s!2.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@372 PS1, Line 372: 00001730: 8acd b502 e801 1db1 028d 9c48 01e8 b520 ...........H... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@418 PS1, Line 418: 00001a10: 1e24 70c0 e804 8ae8 e85b ff59 5f5d c320 .$p......[.Y_]. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@457 PS1, Line 457: 00001c80: 0ac0 7526 8d9c 4c01 66b8 c409 0000 e820 ..u&..L.f...... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@621 PS1, Line 621: 000026c0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@872 PS1, Line 872: 00003670: 015e c332 c0c3 6650 532e 8b1e 1602 b220 .^.2..fPS...... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1271 PS1, Line 1271: 00004f60: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1544 PS1, Line 1544: 00006070: ff00 0002 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1549 PS1, Line 1549: 000060c0: 0300 0000 0000 0000 0030 7500 3075 0020 .........0u.0u. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1571 PS1, Line 1571: 00006220: 910a 0820 0000 0392 0a09 2600 0103 0420 ... ......&.... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1658 PS1, Line 1658: 00006790: 8c04 0100 cdd0 3010 0000 0000 0821 4420 ......0......!D trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1686 PS1, Line 1686: 00006950: 141e 0640 2080 00c0 0000 0000 0d0d 2020 ...@ ......... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@1729 PS1, Line 1729: 00006c00: 4080 1020 9d03 4000 1020 b603 4080 0020 @.. ..@.. ..@.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@2010 PS1, Line 2010: 00007d90: ffff ff00 2105 410a 0000 0056 0041 0320 ....!.A....V.A. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6663.rom.txt@2094 PS1, Line 2094: 000082d0: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt File pci1002,6665.rom.txt:
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@10 PS1, Line 10: 00000090: 1e3e 7800 80b8 5840 2c0d a501 00c6 cc20 .>x...X@,...... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@19 PS1, Line 19: 00000120: 6e64 2020 2020 2020 2020 2020 2020 2020 nd trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@20 PS1, Line 20: 00000130: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@36 PS1, Line 36: 00000230: 0000 8003 4000 290f 0080 0000 414d 4420 ....@.).....AMD trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@542 PS1, Line 542: 000021d0: b822 06e8 eeff c3b8 3f06 e8e7 ffc3 b820 ."......?...... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@756 PS1, Line 756: 00002f30: fa15 7507 b501 bb18 00eb 0b80 fa14 7520 ..u...........u trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1487 PS1, Line 1487: 00005ce0: 0000 0000 00c3 0100 0000 0006 3075 0020 ............0u. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1659 PS1, Line 1659: 000067a0: 4000 1020 b603 4080 0020 cf03 4000 0020 @.. ..@.. ..@.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1702 PS1, Line 1702: 00006a50: 0324 4114 0015 0541 0601 0a0a 1541 0320 .$A....A.....A. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1726 PS1, Line 1726: 00006bd0: 5044 0828 0040 3071 0920 0800 0075 0920 PD.(.@0q. ...u. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1780 PS1, Line 1780: 00006f30: 1f49 0e00 0725 eb09 fe01 252b 0801 5420 .I...%....%+..T trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@1823 PS1, Line 1823: 000071e0: 0125 f705 015b 7a28 0025 0000 0049 2020 .%...[z(.%...I trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C6665.rom.txt@2025 PS1, Line 2025: 00007e80: 6480 0a1c 0001 2480 0a1d 000d 2580 0a20 d.....$.....%.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt File pci1002,990b.rom.txt:
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@13 PS1, Line 13: 000000c0: 2f20 2020 2020 2020 2020 2020 2020 2020 / trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@14 PS1, Line 14: 000000d0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@15 PS1, Line 15: 000000e0: 2020 2020 2020 2020 2020 2020 2020 2020 trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@23 PS1, Line 23: 00000160: 3636 2e31 0032 3532 3735 3620 2000 2020 66.1.252756 . trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@29 PS1, Line 29: 000001c0: 0000 0003 7900 1f0f 0080 0000 414d 4420 ....y.......AMD trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@434 PS1, Line 434: 00001b10: 2224 70c0 e804 8ae8 e85b ff59 5f5d c320 "$p......[.Y_]. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@638 PS1, Line 638: 000027d0: 032a fbc0 e303 8aeb 80fb 1872 0380 cd20 .*.........r... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@713 PS1, Line 713: 00002c80: ca40 8d9c 5803 e840 11a8 0274 0380 ca20 .@..X..@...t... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@907 PS1, Line 907: 000038a0: 0a66 83e8 20e8 effd 6689 4404 c744 0820 .f.. ...f.D..D. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@930 PS1, Line 930: 00003a10: 10eb 0480 4c28 20f6 4534 0175 05c7 4420 ....L( .E4.u..D trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@945 PS1, Line 945: 00003b00: 0175 0333 ffc3 5653 33ff e86c fb8b 5c20 .u.3..VS3..l..\ trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@1359 PS1, Line 1359: 000054e0: 1f8c 4f08 8c47 108c 4f18 8c4f 1c8c 4f20 ..O..G..O..O..O trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@1514 PS1, Line 1514: 00005e90: 268a 6737 b540 6633 c0eb 0666 b820 0720 &.g7.@f3...f. . trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@1607 PS1, Line 1607: 00006460: 282c 0c11 252a 141e 3236 0f13 272c 1b20 (,..%*..26..',. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@2230 PS1, Line 2230: 00008b50: f3a5 13c9 f3a4 8aca 2bf1 2bf9 81c6 0020 ........+.+.... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@2254 PS1, Line 2254: 00008cd0: 80d2 ecc3 e8f0 fcec c3e8 f8ff b2c0 b020 ............... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@2515 PS1, Line 2515: 00009d20: c580 7401 468b cbf3 a483 fb20 7407 b920 ..t.F...... t.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3339 PS1, Line 3339: 0000d0a0: ffff ff08 2000 0024 3088 8303 0406 0020 .... ..$0...... trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3474 PS1, Line 3474: 0000d910: ffff ff1e 2100 001e 2200 0320 2100 2620 ....!...".. !.& trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3522 PS1, Line 3522: 0000dc10: 3418 0251 0154 0034 1854 003b 185b 7a20 4..Q.T.4.T.;.[z trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3723 PS1, Line 3723: 0000e8a0: 0f62 4041 3703 0001 0a05 2040 0d25 0820 .b@A7..... @.%. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3819 PS1, Line 3819: 0000eea0: 0840 1540 1540 1540 1509 2020 2020 2020 .@.@.@.@.. trailing whitespace
https://review.coreboot.org/#/c/31944/1/pci1002%2C990b.rom.txt@3825 PS1, Line 3825: 0000ef00: 0008 4015 4015 4015 4015 0920 2020 2020 ..@.@.@.@.. trailing whitespace