Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75607?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75607/comment/54433b09_89e6ae04 : PS1, Line 7: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S I’d make it two commits:
mb/google/rex: Select SOC_INTEL_METEORLAKE_U_P
https://review.coreboot.org/c/coreboot/+/75607/comment/5dfc4547_832bfa97 : PS1, Line 9: This patch ensures that mainboards built with Intel Meteor Lake SoC : are able to specify the correct SoC type between MTL-U/P and MTL-S. : : It will help to override the FSP UPD parameters properly. Looking at the diff, that’s too broad? Maybe (for each board):
The rex boards use a Meteor Lake U…, so select it. Currently, there is no functional difference, but in the future FSP UPD parameters can be overridden properly.