Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45812 )
Change subject: amdfwtool: Use a variable to get the return value of write ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45812/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/45812/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1759: retval = 1; Output an error message? This would make it look like it passed, but still return an errorcode if someone were to check. I'd certainly be confused.
https://review.coreboot.org/c/coreboot/+/45812/1/util/amdfwtool/amdfwtool.c@... PS1, Line 1762: Error: coul Not related to this patch, but really, all the error messages should go to stderr if you wanted to change that in a follow-on patch. Up to you.