Attention is currently required from: Paul Menzel, Balaji Manigandan, Patrick Rudolph.
Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60259 )
Change subject: src/soc/intel/alderlake/: Add Alder Lake FSP headers for FSP v2511 Previous FSP version was v2471.
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60259/comment/78c021d4_cee6c314
PS1, Line 7: Meminit function call in coreboot has been updated as per new FSP
: UPD and DQS in headers.
:
: src/soc/intel/alderlake/meminit.c : Changes adopted as per new FSP DQS &
: UPD calls.
: src/soc/intel/alderlake/fsp_params.c : Updated LpmStateEnableMask UPD
The message summary still does not follow the common style. […]
Formatted the commit message. Please review.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c576f3
Gerrit-Change-Number: 60259
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 21 Dec 2021 21:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment