20 Feb
2019
20 Feb
'19
12:16 p.m.
Yongqiang Niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31478 )
Change subject: mediatek/mt8183: Add display driver ......................................................................
Patch Set 3:
Patch Set 3:
(3 comments)
Is it possible to merge with 8173/ddp.c, then move to common/ddp.c?
there are many function and hardware register define difference between mt8183 and mt8173, i suppose keep them in different c file is better.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4aecc58d081f14f5d136b9ff8e813e6f40f78eb
Gerrit-Change-Number: 31478
Gerrit-PatchSet: 3
Gerrit-Owner: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-Reviewer: Chun-ta Lin itspeter@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: yongqiang niu yongqiang.niu@mediatek.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Yongqiang Niu yongqiang.niu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 11:16:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment