Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31725 )
Change subject: src/arch: Upgrading SMBIOS to latest version 3.2.
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31725/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31725/2//COMMIT_MSG@7
PS2, Line 7: Upgrading
1. Please use imperative mood: Upgrade …
2. Please remove the dot/period at the end of the commit message summary
https://review.coreboot.org/#/c/31725/2//COMMIT_MSG@9
PS2, Line 9: "This is second of 2 patches upgrading the SMBIOS interface to the latest 3.2"
Please remove the quotes, and add a blank line below.
Additionally, where is the first patch?
It’d be great, if you could summarize the changes in the new version.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf11bedfd9d827cc20cf7a1812022f07b52f6a1e
Gerrit-Change-Number: 31725
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Mar 2019 12:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment