Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31837 )
Change subject: drivers/intel/fsp2_0: fix TPM setup and MRC cache hash logic
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31837/3/src/security/vboot/secdata_tpm.c
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/31837/3/src/security/vboot/secdata_tpm.c@453
PS3, Line 453: CONFIG(VBOOT_STARTS_IN_ROMSTAGE))
I think we still need to consider killing VBOOT_STARTS_IN_ROMSTAGE. […]
As I told you. May work for Google but not for everyone else. I am fine with it, if Google takes the effort porting all old platforms from FSP 1.0/1.1 to VBOOT_STARTS_IN_BOOTBLOCK
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ba91c275c33245be61041cb592e52f861dbafe6
Gerrit-Change-Number: 31837
Gerrit-PatchSet: 5
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 13 Mar 2019 08:02:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment