Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45614 )
Change subject: nb/intel/sandybridge: Move DEFAULT_MCHBAR to Kconfig
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45614/2/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_mrc.c:
https://review.coreboot.org/c/coreboot/+/45614/2/src/northbridge/intel/sandy...
PS2, Line 232: (uintptr_t)
This cast isn't necessary anymore, but I think everything regarding the MRC path could be cleaned anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7722daafd18f30aa5b5d2fe6b21abecd498f4089
Gerrit-Change-Number: 45614
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 22 Sep 2020 21:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment