build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31549 )
Change subject: cpu/x86/pae/pgtbl: Add memset with PAE ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h File src/include/cpu/x86/pae.h:
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@60 PS4, Line 60: uint32_t addr_lo; code indent should use tabs where possible
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@60 PS4, Line 60: uint32_t addr_lo; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@61 PS4, Line 61: uint32_t addr_hi; code indent should use tabs where possible
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@61 PS4, Line 61: uint32_t addr_hi; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@64 PS4, Line 64: struct pde pd[2048]; code indent should use tabs where possible
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@64 PS4, Line 64: struct pde pd[2048]; please, no spaces at the start of a line
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@65 PS4, Line 65: struct pde pdp[512]; code indent should use tabs where possible
https://review.coreboot.org/#/c/31549/4/src/include/cpu/x86/pae.h@65 PS4, Line 65: struct pde pdp[512]; please, no spaces at the start of a line