Attention is currently required from: Felix Held, Saurabh Mishra, Subrata Banik.
Paul Menzel has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add pantherlake soc support for fatcat
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83419/comment/a0158c2b_22ace974?usp... :
PS3, Line 7: for fatcat
Redundant as already part of prefix.
https://review.coreboot.org/c/coreboot/+/83419/comment/7d66605a_71d4eec7?usp... :
PS3, Line 7: pantherlake soc
Panther Lake SOC
https://review.coreboot.org/c/coreboot/+/83419/comment/a4a05649_5612b3aa?usp... :
PS3, Line 9: Details:
Unneeded.
https://review.coreboot.org/c/coreboot/+/83419/comment/c33d845e_d900abc0?usp... :
PS3, Line 10: - This patch adds initial support required to build google/fatcat
Maybe give background that google/fatcat was added with Meteor Lake support as a workaround.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 3
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Jul 2024 06:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No