[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/zork: rename baseboard GPIO table getter for clarity

[Matt DeVillier (Code Review)]

Attention is currently required from: Jason Nien, Martin Roth.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69453 )

Change subject: mb/google/zork: rename baseboard GPIO table getter for clarity
......................................................................

mb/google/zork: rename baseboard GPIO table getter for clarity

Rename variant_pcie_gpio_table() to baseboard_pcie_gpio_table(), since
the GPIO table comes from the baseboard (and is not overridden by any
variant).

Drop the __weak qualifier as this function is not overridden.

This is similar to the change made for skyrim in CB:67809

Change-Id: Idd8ea3446ab7940b21265a3ed8080ba4029c4ff7
Signed-off-by: Matt DeVillier 
---
M src/mainboard/google/zork/bootblock.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
4 files changed, 23 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/69453/1

diff --git a/src/mainboard/google/zork/bootblock.c b/src/mainboard/google/zork/bootblock.c
index 96cbe4d..022a5e0 100644
--- a/src/mainboard/google/zork/bootblock.c
+++ b/src/mainboard/google/zork/bootblock.c
@@ -12,5 +12,5 @@
    gpios = variant_bootblock_gpio_table(&num_gpios, acpi_get_sleep_type());
    gpio_configure_pads(gpios, num_gpios);

-	variant_pcie_gpio_configure();
+	baseboard_pcie_gpio_configure();
 }
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index 6dc3595..70e456c 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -248,7 +248,7 @@
    gpio_set(GPIO_42, 1);
 }

-__weak void variant_pcie_gpio_configure(void)
+void baseboard_pcie_gpio_configure(void)
 {
    static const struct soc_amd_gpio pcie_gpio_table[] = {
    	/* PCIE_RST1_L - Variable timings (May remove) */
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 8d264c8..455684e 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -258,7 +258,7 @@
    gpio_set(GPIO_42, 1);
 }

-__weak void variant_pcie_gpio_configure(void)
+void baseboard_pcie_gpio_configure(void)
 {
    static const struct soc_amd_gpio pcie_gpio_table[] = {
    	/* NVME_AUX_RESET_L */
diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
index 11926d1..c76ca02 100644
--- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
@@ -47,8 +47,8 @@
 void variant_bluetooth_update(void);
 /* Update touchscreen configuration in devicetree during ramstage. */
 void variant_touchscreen_update(void);
-/* Configure PCIe GPIOs as per variant sequencing requirements. */
-void variant_pcie_gpio_configure(void);
+/* Configure PCIe GPIOs as per baseboard sequencing requirements. */
+void baseboard_pcie_gpio_configure(void);

/* Per variant FSP-S initialization, default implementation in baseboard and
  * overridable by the variant. */