Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38286 )
Change subject: mb/tglrvp: update gpio pin mux for NVMe
......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38286/4/src/mainboard/intel/tglrvp/...
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:
https://review.coreboot.org/c/coreboot/+/38286/4/src/mainboard/intel/tglrvp/...
PS4, Line 22: /* PCH M.2 SSD */
care to give a tab to start?
Ack
https://review.coreboot.org/c/coreboot/+/38286/4/src/mainboard/intel/tglrvp/...
PS4, Line 23:
remove white space?
This is one space, we should have after ,
https://review.coreboot.org/c/coreboot/+/38286/4/src/mainboard/intel/tglrvp/...
PS4, Line 24:
remove white space?
this is 2 spaces. Remove 1 spaces.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4b85db667c27d266d2ed5a4aa4f4dffa3dd527e
Gerrit-Change-Number: 38286
Gerrit-PatchSet: 5
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Tue, 14 Jan 2020 21:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment