Attention is currently required from: Jędrzej Ciupis, Subrata Banik.
Felix Held has posted comments on this change by Jędrzej Ciupis. ( https://review.coreboot.org/c/coreboot/+/83884?usp=email )
Change subject: soc/intel/jasperlake: Add CrashLog implementation for Intel JSL
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/jasperlake/crashlog_lib.c:
PS2:
haven't compared this with the code in the other socs, but i wonder if some code in there is actually common across all intel socs that support this. if so, it might be good to make the common code common to deduplicate things
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83884?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia18a79d8de849d556b4b8fd0e6b43090311eb23f
Gerrit-Change-Number: 83884
Gerrit-PatchSet: 2
Gerrit-Owner: Jędrzej Ciupis
jciupis@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Jędrzej Ciupis
jciupis@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Thu, 22 Aug 2024 13:13:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No