Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32219 )
Change subject: mb/google/hatch: Support 16MiB fmap ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32219/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/32219/2/src/mainboard/google/hatch/Kconfig@4 PS2, Line 4: select BOARD_ROMSIZE_KB_32768 This config will have to be updated as well. Looking at this again, we can do something like this:
In Kconfig.name each board can set either BOARD_ROMSIZE_KB_32768 or BOARD_ROMSIZE_KB_16384 and FMDFILE can do the same selection as you have right now but based on BOARD_ROMSIZE_KB_* directly. Then, we can avoid having the HATCH_HAS_16MB_FLASH altogether.