Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42373 )
Change subject: mainboard/hp: Add ProBook 6360b ......................................................................
Patch Set 10: Code-Review+2
(5 comments)
https://review.coreboot.org/c/coreboot/+/42373/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42373/10//COMMIT_MSG@11 PS10, Line 11: Patchset 4: : * update the board Kconfig name : * replace spaces with tabs : * fix the subsystem id : : Patchset 5: : * update the variant directory : : Patchset 6: : * use alphabetical order in Kconfig files : * set flashrom support to yes in board_info : * update comment about SATA ports : : Patchset 7: : * add a VBT : : Patchset 8: : * eSATA port is tested : : Patchset 9: : * fix fan control issue : : Patchset 10: : * move fan control fix to a separate commit I'd drop this, because patchsets are specific to Gerrit and don't end up in the repo
https://review.coreboot.org/c/coreboot/+/42373/10//COMMIT_MSG@52 PS10, Line 52: TPM maybe expand:
* TPM (SeaBIOS detects it, no further test done)
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c File src/ec/hp/kbc1126/ec.c:
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c@121 PS9, Line 121: int timeout = 0x17ff;
To be clear, these three lines are copy-pasted from the send_kbc_* functions above, that are almost […]
Ack
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c@117 PS9, Line 117: kbc1126_kbdled(conf->ec_ctrl_reg, 0); : : /* The EC needs additional time to process the first command on a cold : boot. */ : int timeout = 0x17ff; : while ((inb(conf->ec_cmd_port) & KBD_IBF) && --timeout) :
No, the EC only needs a lot more time after receiving the second data value for the LEDs.
Ack
https://review.coreboot.org/c/coreboot/+/42373/9/src/ec/hp/kbc1126/ec.c@123 PS9, Line 123: udelay(10);
- Please use the stopwatch framework, and print out the waited time. […]
Ack