Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31871 )
Change subject: Remove leftover files
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31871/1/src/lib/debug.c
File src/lib/debug.c:
https://review.coreboot.org/#/c/31871/1/src/lib/debug.c@a20
PS1, Line 20:
Hmm.. ever since introduction of PCI MMCONF, bottom 12 bits of dev have been register. So broken and nobody noticed for 6 years?
https://review.coreboot.org/#/c/31871/1/src/lib/debug.c@a90
PS1, Line 90:
Say again? Read 256 bytes from single IO port?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7fa27a2cbc73b4acae41373a51f600f32b9002bf
Gerrit-Change-Number: 31871
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Mar 2019 10:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment