Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85547?usp=email )
Change subject: mb/google/brya: Adjust EC memory map range to support indexed IO
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85547/comment/e89a146d_f19659cf?usp... :
PS3, Line 11: # EC memory map range is 0x900-0x9ff and indexed access is through 0x380
can you please follow https://review.coreboot.org/c/coreboot/+/84919/3/src/mainboard/google/fatcat...
```
# For platform selects EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO
# EC host command ranges are in 0x380-<range??>
# For others
# EC host command ranges are in 0x900-0x9ff
```
btw, what is the range for 0x380 ? like how many bytes, depending on that you should modify the MSB of gen3_dec. if 8 bytes then MSB should be 4 like 0x00040381 (0x380-0x38f).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85547?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide5026b35da7c00deab4464eedfca9d52d294fd6
Gerrit-Change-Number: 85547
Gerrit-PatchSet: 3
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 12 Dec 2024 06:51:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No