Attention is currently required from: Dehui Sun, Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85362?usp=email )
Change subject: soc/mediatek/mt8196: Add booker driver ......................................................................
Patch Set 9:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85362/comment/a4b5fcb5_8c177b2d?usp... : PS9, Line 9: The MTK booker The MediaTek booker (the customized ARM CI-700)
https://review.coreboot.org/c/coreboot/+/85362/comment/b930f878_0828526c?usp... : PS9, Line 15: it can `it needs to` ?
https://review.coreboot.org/c/coreboot/+/85362/comment/c1d3b805_bbd82d55?usp... : PS9, Line 15: it can : set bit[3] (disable_cmo_prop) to 0 in the por_sbsx_cfg_ctl register of : each SBSX node. Does it mean that we need to set the bit 3 (disable_cmo_prop) to `0` in order to propagate the CMO command from DSU ?
File src/soc/mediatek/mt8196/booker.c:
https://review.coreboot.org/c/coreboot/+/85362/comment/0c93ef0d_a009b184?usp... : PS9, Line 11: MCUSYS_PAR_WRAP_BASE just use `MCUCFG_BASE`
https://review.coreboot.org/c/coreboot/+/85362/comment/db410e5e_dca3d215?usp... : PS9, Line 13: 0x00450000 + 0x0A00 please define this