[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede/var/magolor: Configure I2C high and low time

[Ren Kuo (Code Review)]

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46613 )

Change subject: mb/google/dedede/var/magolor: Configure I2C high and low time
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46613/1/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/magolor/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46613/1/src/mainboard/google/dedede... 
PS1, Line 27: .speed = I2C_SPEED_FAST,
            : 			.speed_config[0] = {
            : 				.speed = I2C_SPEED_FAST,
> Is `. […]

from current fsp code, the "speed" will be specified twice.
initial i2c parameters by different power on stages.

FSP code, struct definition:

struct soc_intel_common_config{
    ...
    struct dw_i2c_bus_config
    ...
}

struct dw_i2c_bus_config {
   /* Bus should be enabled prior to ramstage with temporary base */
   ...
   enum i2c_speed speed;
   ...
  /* Specific bus speed configuration */
   struct dw_i2c_speed_config
}

struct dw_i2c_speed_config {
    enum i2c_speed speed;
    uint16_t scl_lcnt;
    uint16_t scl_hcnt;
    uint32_t sda_hold;
};