Attention is currently required from: Gaggery Tsai, Kedar J. Karanje, Subrata Banik, Kane Chen.
Hello Gaggery Tsai, Kedar J. Karanje, Subrata Banik, Kane Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68899
to look at the new patch set (#2).
Change subject: cpu/intel/common: Fix typecasting issue ......................................................................
cpu/intel/common: Fix typecasting issue
The patch fixes the typecasting issue, that is conversion from 'int' to 'unsigned long long int'. This changes value from '0x8000 0000' to '0xFFFF FFFF 8000 0000'.
During unit testing, the argument is getting changed to an unexpected number which is resulting to an exception when IA32_HWP_REQUEST MSR is updated. In this update, the MSR's reserved bits are getting updated, so this causes exception.
TEST= Verified the code on the Gimble. No exception is seen after the fix.
Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com Change-Id: I35d382c792b9df260381b7696f3bbff43d6c4dc2 --- M src/cpu/intel/common/common_init.c 1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/68899/2