[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Add functions to declare ARM GIC V3 hardware

[Julius Werner (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Held, Kyösti Mälkki, Lance Zhao, Tim Wawrzynczak.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email )

Change subject: acpi: Add functions to declare ARM GIC V3 hardware
......................................................................

Patch Set 6:

(1 comment)

File src/arch/arm64/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/76132/comment/ffdb25aa_43566c01 :
PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c
> FelixH and I thought that arch/x86 should be revisited for this, CB:76008.

That's a bit of a different case though since there's no separate guarding Kconfig for those files. In this case the files are already guarded by CONFIG_ACPI_COMMON_MADT_GICC_V3, and CONFIG_ACPI_COMMON_MADT_GICC_V3 should only be enabled for arm64 boards to begin with, so it should be fine to just add this to acpi/Makefile.inc directly. (Although I agree with Kyösti that even in that case it seems like a bad idea and should probably be solved in some other way if possible.)