Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69662 )
Change subject: soc/amd/common: Don't set Wstack-usage option for clang builds
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
It looks like a similar flag for clang is `-Wframe-larger-than=`
gcc has that flag too, but it is less conservative than `-Wstack-usage=`, so it's probably not as good at catching things.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d8b9c26d3fc861615a8553332ed1070974b751b
Gerrit-Change-Number: 69662
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 15 Nov 2022 19:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment