Attention is currently required from: Jakub Czapiga, Angel Pons, Julius Werner.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67918 )
Change subject: tests: Add option for debug symbols & no optimization ......................................................................
Patch Set 2:
(2 comments)
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/67918/comment/ed55411a_eb6fe4c1 PS2, Line 13: DBG=1
We could rid ourselves of this burden: […]
Done. I also updated the comment immediately below, which is what I had copied for this...
https://review.coreboot.org/c/coreboot/+/67918/comment/cf494459_d4af7418 PS2, Line 183: GDB_DEBUG=y
Can we stick to `1` as enabled like it is in case of `COV`? […]
Done.
To fix the issue of it being enable if set to 0, GDB_DEBUG will now be set to zero if uninitialized, then we enable the code if not equal to zero. So off if uninitialized or zero, otherwise on.