13 Apr
2023
13 Apr
'23
5 a.m.
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin.
cong yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74341 )
Change subject: soc/mediatek: Add support for regulator VIO18 ......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/74341/comment/f3561394_51e1df26 PS4, Line 927: case MT6366_VIO18:
Should we assert that `voltage_uv == 1800000`? Please also define a constant marco for `1800000`. […]
1800000 seems to be used in several places in this file, and there are some 2900000/3000000/3300000, do you need to change all 1800000 to macro definitions?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 5
Gerrit-Owner: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 03:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment