[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Refactor and consolidate code for spi base

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43307 )

Change subject: soc/amd/common: Refactor and consolidate code for spi base
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/sp... 
File src/soc/amd/common/block/spi/fch_spi_ctrl.c:

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/sp... 
PS6, Line 33: static inline uint8_t spi_read8(uint8_t reg)
You ack'd the inline and did not address it :(

https://review.coreboot.org/c/coreboot/+/43307/6/src/soc/amd/common/block/sp... 
PS6, Line 35: spi_base
> Ok, that makes sense.

My comments were mostly about the asymmetry of MMIO accessors. When ACPIMMIO banks don't need function call here, why would SPI need?

But looks like there is no plan to unify these accessors even inside SPI, and there is now three different approaches for fundamentally the same thing.