build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31177 )
Change subject: Qcs405: Add SPI chip select assert/de-assert in claim/release bus ......................................................................
Patch Set 4:
(57 comments)
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c File src/soc/qualcomm/qcs405/clock.c:
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@66 PS4, Line 66: { code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@66 PS4, Line 66: { please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@67 PS4, Line 67: .hz = 1000000, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@67 PS4, Line 67: .hz = 1000000, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@68 PS4, Line 68: .hw_ctl = 0x0, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@68 PS4, Line 68: .hw_ctl = 0x0, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@69 PS4, Line 69: .src = SRC_XO_19_2MHZ, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@69 PS4, Line 69: .src = SRC_XO_19_2MHZ, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@70 PS4, Line 70: .div = DIV(48), code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@70 PS4, Line 70: .div = DIV(48), please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@71 PS4, Line 71: //.m = 1, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@72 PS4, Line 72: //.n = 2, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@73 PS4, Line 73: //.d_2 = 4, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@73 PS4, Line 73: //.d_2 = 4, please, no space before tabs
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@73 PS4, Line 73: //.d_2 = 4, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@74 PS4, Line 74: }, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@74 PS4, Line 74: }, please, no space before tabs
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/clock.c@74 PS4, Line 74: }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c File src/soc/qualcomm/qcs405/spi.c:
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@341 PS4, Line 341: } void function return statements are not generally useful
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@352 PS4, Line 352: switch(slave->bus) { switch and case should be at the same indent
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@355 PS4, Line 355: GPIO_PULL_DOWN, GPIO_6MA, GPIO_INPUT); //MISO - IN code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@355 PS4, Line 355: GPIO_PULL_DOWN, GPIO_6MA, GPIO_INPUT); //MISO - IN please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@356 PS4, Line 356: gpio_configure(GPIO(38), 2, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@356 PS4, Line 356: gpio_configure(GPIO(38), 2, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@357 PS4, Line 357: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //MOSI - Out code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@357 PS4, Line 357: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //MOSI - Out please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@358 PS4, Line 358: gpio_configure(GPIO(117), 2, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@358 PS4, Line 358: gpio_configure(GPIO(117), 2, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@359 PS4, Line 359: GPIO_NO_PULL, GPIO_6MA, GPIO_OUTPUT); //SCLK - out code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@359 PS4, Line 359: GPIO_NO_PULL, GPIO_6MA, GPIO_OUTPUT); //SCLK - out please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@360 PS4, Line 360: gpio_configure(GPIO(118), 2, code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@360 PS4, Line 360: gpio_configure(GPIO(118), 2, please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@361 PS4, Line 361: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //CS_0 - out trailing whitespace
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@361 PS4, Line 361: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //CS_0 - out code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@361 PS4, Line 361: GPIO_PULL_DOWN, GPIO_6MA, GPIO_OUTPUT); //CS_0 - out please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@363 PS4, Line 363: break; trailing whitespace
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@364 PS4, Line 364: case 5: code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@364 PS4, Line 364: case 5: please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@366 PS4, Line 366: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@366 PS4, Line 366: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@366 PS4, Line 366: gpio_configure(GPIO(26), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@367 PS4, Line 367: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@367 PS4, Line 367: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@367 PS4, Line 367: gpio_configure(GPIO(27), 3, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@368 PS4, Line 368: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@368 PS4, Line 368: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@368 PS4, Line 368: gpio_configure(GPIO(28), 4, GPIO_PULL_UP, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@369 PS4, Line 369: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); line over 80 characters
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@369 PS4, Line 369: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); code indent should use tabs where possible
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@369 PS4, Line 369: gpio_configure(GPIO(29), 4, GPIO_NO_PULL, GPIO_16MA, GPIO_INPUT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@524 PS4, Line 524: printk(BIOS_ERR, "SPI FIFO read timeout \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@529 PS4, Line 529: }while(!(val & MAX_INPUT_DONE_FLAG)); space required after that close brace '}'
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@529 PS4, Line 529: }while(!(val & MAX_INPUT_DONE_FLAG)); space required before the open parenthesis '('
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@651 PS4, Line 651: printk(BIOS_ERR, "SPI FIFO write timeout \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@656 PS4, Line 656: }while(!(val & MAX_OUTPUT_DONE_FLAG)); space required after that close brace '}'
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@656 PS4, Line 656: }while(!(val & MAX_OUTPUT_DONE_FLAG)); space required before the open parenthesis '('
https://review.coreboot.org/#/c/31177/4/src/soc/qualcomm/qcs405/spi.c@678 PS4, Line 678: printk(BIOS_ERR, "SPI:DBG write not success \n"); unnecessary whitespace before a quoted newline