Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Tarun, Tony Huang.
Subrata Banik has posted comments on this change by Tony Huang. ( https://review.coreboot.org/c/coreboot/+/84139?usp=email )
Change subject: mb/google/ovis/var/deku: Remove DSP setting
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84139/comment/14f4b624_7e61c715?usp... :
PS1, Line 14: TEST=emerge-ovis coreboot
: check dev beep works
I don't have ovis board to confirm.
I see ovis has GPP_H19/GPP_H20 calls SOC_I2C_AUD_WFC_SDA/SCL in the schematic, not sure if this change impacts it.
Drop DSP UPD and confirm dev beep in deku is fine.
@derekhuang@google.com can you please help to test using Ovis?
sure
File src/mainboard/google/rex/variants/deku/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84139/comment/8cd962fb_ee939d79?usp... :
PS1, Line 51:
do you want to override below UPDs as well ?
```
"pch_hda_idisp_link_tmode" = "HDA_TMODE_8T"
"pch_hda_idisp_link_frequency" = "HDA_LINKFREQ_96MHZ"
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia1102dd3dfaa8248b092317edc2a88466adc2bd8
Gerrit-Change-Number: 84139
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 02 Sep 2024 09:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tony Huang
tony-huang@quanta.corp-partner.google.com