Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76891?usp=email )
Change subject: commonlib/fsp_relocate: Fix pe_relocate() return value on success ......................................................................
commonlib/fsp_relocate: Fix pe_relocate() return value on success
Similarily to te_relocate(), on success pe_relocate() should return 0. It has never been an issue so far as pe_relocate() return value is not tested.
Change-Id: I8e531662952d12e1f0ffa34042dab778ea602bfc Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com --- M src/commonlib/fsp_relocate.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76891/1
diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 8027994..4baf5e6 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -281,7 +281,7 @@ img_base_off += delta; write_le32(&ophdr->ImageBase, img_base_off);
- return -1; + return 0; }
static int te_relocate(uintptr_t new_addr, void *te)