build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31177 )
Change subject: Qcs405: Add SPI chip select assert/de-assert in claim/release bus ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c File src/soc/qualcomm/qcs405/spi.c:
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@512 PS2, Line 512: printk(BIOS_ERR, "SPI FIFO read timeout \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@517 PS2, Line 517: }while(!(val & MAX_INPUT_DONE_FLAG)); space required after that close brace '}'
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@517 PS2, Line 517: }while(!(val & MAX_INPUT_DONE_FLAG)); space required before the open parenthesis '('
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@638 PS2, Line 638: printk(BIOS_ERR, "SPI FIFO write timeout \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@643 PS2, Line 643: }while(!(val & MAX_OUTPUT_DONE_FLAG)); space required after that close brace '}'
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@643 PS2, Line 643: }while(!(val & MAX_OUTPUT_DONE_FLAG)); space required before the open parenthesis '('
https://review.coreboot.org/#/c/31177/2/src/soc/qualcomm/qcs405/spi.c@665 PS2, Line 665: printk(BIOS_ERR, "SPI:DBG write not success \n"); unnecessary whitespace before a quoted newline