Attention is currently required from: Anjaneya "Reddy" Chagam, Subrata Banik, Jonathan Zhang, Ravishankar Sarawadi, Johnny Lin, Paul Menzel, Christian Walter, Tim Wawrzynczak, Arthur Heymans, Michael Niewöhner, Tim Chu.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63472 )
Change subject: soc/intel: Remove dmi driver
......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63472/comment/1642ca07_022d314b
PS6, Line 9: Remove dmi driver as it's replaced with gpmr driver
: Update old platforms which use dmi.h
Please format it as a list, or do not break lines after sentences, if it’s not a new paragraph.
Ack
https://review.coreboot.org/c/coreboot/+/63472/comment/183f979c_975a467a
PS6, Line 11:
Tested how?
Test is done in TGL platform and these changes are removing unused code and header file(dmi.h)
File src/mainboard/ocp/deltalake/bootblock.c:
https://review.coreboot.org/c/coreboot/+/63472/comment/16dd3f0c_086939b2
PS9, Line 15: #define PCR_DMI_LPCIOD 0x2770
: #define PCR_DMI_LPCIOE 0x2774
put this below `ASPEED_SIO_PORT` macro to maintain the order
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib340ff1ab7fd88b1e7b3860ffec055a75e562de7
Gerrit-Change-Number: 63472
Gerrit-PatchSet: 11
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 11 Apr 2022 23:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment