Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58962 )
Change subject: lib/prog_loaders, soc/amd/: Make payload_preload use cbfs_preload
......................................................................
Patch Set 1:
(1 comment)
File src/lib/prog_loaders.c:
https://review.coreboot.org/c/coreboot/+/58962/comment/af3316fa_8ba641ce
PS1, Line 133: return;
So the initial thought was that the preload methods are all no-ops when not enabled. […]
Hmm... yeah... I think I'm just worried it can be confusing to see `payload_preload()` called unconditionally like that and having to explicitly be aware of that this actually doesn't do anything if the Kconfig is not enabled. I know we have that pattern elsewhere in coreboot too but usually it's less invasive stuff (like timestamps). I don't know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58962
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc521b238620ff52b8ba481cd3c10e5c4f1394bd
Gerrit-Change-Number: 58962
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 16 Nov 2021 17:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment