Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43890 )
Change subject: mb/purism/librem_skl: Relocate devicetree FSP settings ......................................................................
Patch Set 2: Code-Review-1
(4 comments)
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 160: # FIXME: corresponding device entry is missing so? coreboot doesn't do anything with it
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 168: # FIXME: does not match devicetree! this is necessary in order to have the ME status registers printed in cbmem
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 169: register "HeciEnabled" = "0" not sure this has any effect when ME disabled via HAP
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem... PS2, Line 195: # FIXME: This seems specific to Librem 15 it's not, WiFi is attached to RP5 on all librem_skl variants