Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41712 )
Change subject: soc/intel/common: Add restore and enable GPIO PM
......................................................................
Patch Set 1:
Patch Set 1:
oh no issue in chip.c, gpio_soc_defs already shift the number. We only need to figure out ASL part.
The issue is in devicetree PM config fill instead of disabling gpio PM for 0, 1, 2, 4, 5, it is disabling for 0, 1, 2, 3, 4, and asl does not restore it for COMM3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If5e4553d568a872de234a2d671118acbae0a6159
Gerrit-Change-Number: 41712
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 26 May 2020 07:36:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment