Felix Held has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83927?usp=email )
Change subject: soc/mediatek/mt8196: Add I2C driver support
......................................................................
Patch Set 20:
(1 comment)
File src/soc/mediatek/mt8196/i2c.c:
https://review.coreboot.org/c/coreboot/+/83927/comment/6071fd25_266645a9?usp... :
PS20, Line 101: #define PAD_FUNC(name, func) {GPIO(name), PAD_##name##_FUNC_##func}
i'd suggest moving this define and also the PAD_FUNC_SEL define from the spi flash code to either the soc's gpio.h or the common mediatek gpio_common.h, since that seems to be gpio-related and only indirectly related to the spi or i2c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83927?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I617ad8a43ce8b492b1a0e5dc06c1f0ffe7d92b5e
Gerrit-Change-Number: 83927
Gerrit-PatchSet: 20
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ot_hao.han@mediatek.com
ot_hao.han@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 24 Aug 2024 13:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No