Attention is currently required from: Máté Kukri.
Angel Pons has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )
Change subject: [WIP] OptiPlex 3050 Micro port ......................................................................
Patch Set 14: Code-Review+1
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82053/comment/1d0ce546_e84dd028?usp... : PS14, Line 7: [WIP] Should this be removed before submitting?
File src/mainboard/dell/optiplex_3050/cmos.layout:
https://review.coreboot.org/c/coreboot/+/82053/comment/7c21e300_208be40c?usp... : PS14, Line 25: 416 128 r 0 vbnv Does this board use vboot/ChromeOS?
File src/mainboard/dell/optiplex_3050/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82053/comment/e50b238d_50f0506a?usp... : PS14, Line 13: register "PrimaryDisplay" = "Display_iGFX" Is this needed? It's not wrong, though.
https://review.coreboot.org/c/coreboot/+/82053/comment/b46b9630_dcf08a4d?usp... : PS14, Line 18: OC0 That's a lot of ports on OC0, it feels wrong
https://review.coreboot.org/c/coreboot/+/82053/comment/a85d62d0_9c95e45e?usp... : PS14, Line 55: device ref pcie_rp21 on Which device is this? Would be nice to add a comment
File src/mainboard/dell/optiplex_3050/ramstage.c:
https://review.coreboot.org/c/coreboot/+/82053/comment/3262753c_efdd7899?usp... : PS14, Line 11: static void init_mainboard(void *chip_info) : { : } : : struct chip_operations mainboard_ops = { : .init = init_mainboard, : }; If this does nothing, is it needed? Should GPIOs be configured in there?