Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44805 )
Change subject: mb/google/kaisa: Override power limits configuration ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-2
Hi David,
So this is a incorrect approch as we already have `src/mainboard/google/hatch/variants/baseboard/mainboard.c` shared between the boards.
What you probably need to do here to generalise it as parameteric on the variants is have each variant have a header with the `#define` differences. This way when each board is compiled the common mainboard.c will get the correct constants.
Sorry, I don't understand what you mean. could you share sample code for my reference? or would you help to update this CL? Thanks.
Look in `src/mainboard/google/hatch/variants/baseboard/mainboard.c` that is shared between Puff boards. All you are doing here is overriding the common code with duplicate implementations in each variant. Fix the common code in `src/mainboard/google/hatch/variants/baseboard/mainboard.c`