Attention is currently required from: Daniel Peng, Eric Lai, Kapil Porwal, Nick Vaccaro, Shawn Ku.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80764?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/glassway: Initialize gpio table
......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80764/comment/f1f5dcce_e8df0f98 :
PS1, Line 7: gpio
GPIO
https://review.coreboot.org/c/coreboot/+/80764/comment/d633ef8a_e5b39bf4 :
PS1, Line 7: Initialize
Add
https://review.coreboot.org/c/coreboot/+/80764/comment/d465a10d_37f2e390 :
PS1, Line 9: Refer
Refer to
https://review.coreboot.org/c/coreboot/+/80764/comment/b8c29f8a_2fb07dd1 :
PS1, Line 9: devicetree
GPIO
File src/mainboard/google/brya/variants/glassway/gpio.c:
https://review.coreboot.org/c/coreboot/+/80764/comment/e9214378_941380cf :
PS1, Line 9: nivviks
Is that correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0de743746160c6eb081cb9a061ac1703b01ba5b4
Gerrit-Change-Number: 80764
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 26 Feb 2024 12:29:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment