Attention is currently required from: Varshit B Pandya. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56655 )
Change subject: mb/google/brya: Configure H21 as GPO and A17 as low ......................................................................
Patch Set 6:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56655/comment/466a5d5b_a520bd28 PS6, Line 9: donot do not
https://review.coreboot.org/c/coreboot/+/56655/comment/b470c195_f3761705 PS6, Line 10: H21 in NF1 that is IMGCLKOUT Please add a period/dot at the end of sentences.
https://review.coreboot.org/c/coreboot/+/56655/comment/ba3e07bd_562a15c9 PS6, Line 11: oscialltor oscillator
https://review.coreboot.org/c/coreboot/+/56655/comment/0355f218_04682c6a PS6, Line 11: H21 is used to enable this oscialltor so configuring it as 1 Please add a period/dot at the end of sentences.
https://review.coreboot.org/c/coreboot/+/56655/comment/579651e4_207d01d7 PS6, Line 11: configuring configure
https://review.coreboot.org/c/coreboot/+/56655/comment/552d806e_a97087c5 PS6, Line 13: A17 is configured as high while _ON method is called by driver and : it is configured as low when _OFF method is called by driver. : Hence coreboot should configure it as low on boot. This should be a separate change-set. Why are you reverting this again in https://review.coreboot.org/c/coreboot/+/56882/2/src/mainboard/google/brya/v...