Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix SKUID config for burnet/esche ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46442/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/1/src/mainboard/google/kukui/... PS1, Line 99: if (CONFIG(BOARD_GOOGLE_BURNET)) { : cached_sku_id = (0x10 | get_adc_index(SKU_ID_CHANNEL)); : return cached_sku_id; : } :
The LCM_ID HW strap of kappa & juniper are actually 1. […]
so we should hard-code LCM_ID to 1 for all JACUZZI device for now? and sure, we'll keep checking hardware in parallel. thanks.