9 Nov
2020
9 Nov
'20
1:23 p.m.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46458 )
Change subject: tests: Add lib/imd_cbmem-test test case ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46458/3/tests/lib/imd_cbmem-test.c File tests/lib/imd_cbmem-test.c:
https://review.coreboot.org/c/coreboot/+/46458/3/tests/lib/imd_cbmem-test.c@... PS3, Line 191: 0x10
IDs do not need to be sequential. […]
Maybe change them to be non-sequential, and also add a comment that they don't have to be sequential.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie893b5e8fc91c230ff96a14146085de16d78b1c1
Gerrit-Change-Number: 46458
Gerrit-PatchSet: 5
Gerrit-Owner: Name of user not set #1003143
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jan Dabros jsd@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Nov 2020 21:23:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1003143
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment