Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31421 )
Change subject: SMBIOS: Update BMC Interface Type field ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31421/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/31421/2/src/include/smbios.h@484 PS2, Line 484: SMBIOS_BMC_INTERFACE_KCS = 0x01, : SMBIOS_BMC_INTERFACE_SMIC = 0x02, : SMBIOS_BMC_INTERFACE_BLOCK = 0x03, : SMBIOS_BMC_INTERFACE_SMBUS = 0x04, : The equates are not needed, this is an enum. SMBIOS_BMC_INTERFACE_UNKNOWN = 0, SMBIOS_BMC_INTERFACE_KCS, SMBIOS_BMC_INTERFACE_SMIC, SMBIOS_BMC_INTERFACE_BLOCK, SMBIOS_BMC_INTERFACE_SMBUS, }}