[coreboot-gerrit] [M] Change in coreboot[main]: lib/*stage_cache: Don't save BSS in stage cache

[Julius Werner (Code Review)]

Attention is currently required from: Andrey Petrov, Arthur Heymans, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Ronak Kanabar.

Julius Werner has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/82419?usp=email )

Change subject: lib/*stage_cache: Don't save BSS in stage cache
......................................................................

Patch Set 12:

(3 comments)

File src/include/program_loading.h:

https://review.coreboot.org/c/coreboot/+/82419/comment/363587ce_1713f56c?usp... :
PS12, Line 106: flen
prog_set_fsize?

File src/lib/cbfs.c:

https://review.coreboot.org/c/coreboot/+/82419/comment/76a0991d_e6f3d0f7?usp... :
PS12, Line 576: 	prog_set_area(pstage, (void *)(uintptr_t)be64toh(sattr->loadaddr), be32toh(sattr->memlen));
Unclear why you remove the line break here? It looks like it doesn't fit 96 chars... (or are we doing 100 chars now? I might have missed that memo).

File src/lib/rmodule.c:

https://review.coreboot.org/c/coreboot/+/82419/comment/048791a6_b54a49c3?usp... :
PS12, Line 71: 	return module->header->bss_begin;
I think(?) this should technically be `module->header->bss_begin - module->header->module_link_start_address`, even though the latter may always be 0 in practice (cf. `rmodule_entry_offset()`).