Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Rob Barnes, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58985 )
Change subject: soc/amd/{cezanne,picasso}: Stop passing base for fspm.bin
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
also still works with this on a mandolin with picasso apu.
without having checked, i assume that we now can rip out everything around FSP_M_ADDR in soc/amd, so it would be good if you could look into that. that ould also avoid the problem that we need to reserve the maximum amount of memory a debug build of the fsp-m needs even though the release builds are significantly smaller
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibef849d5b3f0290cb7b7c5ff18aabe002bf53344
Gerrit-Change-Number: 58985
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 05 Nov 2021 21:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment