Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Angel Pons, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59311 )
Change subject: soc/intel/../thermal: Modified `pch_get_ltt_value()` return type
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59311/comment/273d898c_04dd7c8b
PS1, Line 7: Modified `pch_get_ltt_value()` return type
How about this:
Change return type of `pch_get_ltt_value()` to uint32
Or this, since you're mentioning a bug number below:
Fix return type of `pch_get_ltt_value()`
https://review.coreboot.org/c/coreboot/+/59311/comment/42b69758_57284dd8
PS1, Line 9: This patch modifies the pch_get_ltt_value() function return type from
: uint16_t to uint32_t.
Please explain why. That bug number below isn't very helpful for outstanding people.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59311
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5f46ccb457b9cfebf13a512eabb3fb0fab8adb39
Gerrit-Change-Number: 59311
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 16 Nov 2021 04:00:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment