Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38492 )
Change subject: mb/google/hatch/var/jinlon: Remove fan control from dptf
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38492/1//COMMIT_MSG@7
PS1, Line 7: Remove fan control from dptf
This sentence sounds a bit weird. Instead, I would use:
Remove DPTF fan control
Note that, just like "EC", "DPTF" is also an acronym, so it should be in uppercase.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ada4fe72eee260fecf45d00510da8b91e3f10a4
Gerrit-Change-Number: 38492
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 Jan 2020 12:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment