Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )
Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43678/4/src/lib/reset.c
File src/lib/reset.c:
https://review.coreboot.org/c/coreboot/+/43678/4/src/lib/reset.c@14
PS4, Line 14: board_reset
Part of me feels like this whole function should just be made weak or we should replace the compilat […]
I'm not in favor of making this weak for the reason I already mentioned in the top level response to eric, but I like the CUSTOM_BOARD_RESET idea. I'll switch to that.
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43678
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6775b2e049d6cfd9f78f2e07a941f6cc5be254b8
Gerrit-Change-Number: 43678
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jul 2020 16:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment