[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mp_init.c: Don't overwrite the global variable per CPU

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51184 )

Change subject: cpu/x86/mp_init.c: Don't overwrite the global variable per CPU
......................................................................

cpu/x86/mp_init.c: Don't overwrite the global variable per CPU

Global variables are located in .bss and not on the CPU stack.
Overwriting them a per CPU case is bound to cause race conditions. In
this case it is even just plainly wrong.

Change-Id: Iaef26fa996f7e30b6e4c4941683026b8a29a5fd1
Signed-off-by: Arthur Heymans 
---
M src/cpu/x86/mp_init.c
1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/51184/1

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index 6aa40f0..4d533e6 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -732,7 +732,6 @@
     */
 #if CONFIG(X86_SMM_LOADER_VERSION2)
    perm_smbase = smm_get_cpu_smbase(cpu);
-	mp_state.perm_smbase = perm_smbase;
    if (!perm_smbase) {
    	printk(BIOS_ERR, "%s: bad SMBASE for CPU %d\n", __func__, cpu);
    	return;