Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig
File src/drivers/intel/ish/Kconfig:
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig@2
PS1, Line 2: bool "Support Intel ISH driver that publishes _DSD information"
I had it selectable so you don't need extra drivers. […]
When there is a quoted string after the Kconfig type this option shows up in the Kconfig gui. That's what I mean by user selectable. Your selection in the link provided will work regardless of a quoted string or not.
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig@3
PS1, Line 3: depends on ARCH_X86
I don't think this is really necessary in practice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8be986185282521aee574027503eaf8968e1508
Gerrit-Change-Number: 31682
Gerrit-PatchSet: 2
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 01 Mar 2019 17:53:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Gerrit-MessageType: comment