Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81907?usp=email )
Change subject: util/lint: Add lint rule to avoid duplicated includes ......................................................................
util/lint: Add lint rule to avoid duplicated includes
Change-Id: Ia14c73f0bffa6ee4b73254d71836f793af8771c4 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- A util/lint/lint-stable-031-includes.sh 1 file changed, 76 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/81907/1
diff --git a/util/lint/lint-stable-031-includes.sh b/util/lint/lint-stable-031-includes.sh new file mode 100644 index 0000000..222f6a4 --- /dev/null +++ b/util/lint/lint-stable-031-includes.sh @@ -0,0 +1,76 @@ +#!/usr/bin/env sh +# SPDX-License-Identifier: GPL-2.0-or-later +# +# DESCR: Verify that included files are not duplicated +# +LINTDIR="$( + cd -- "$(dirname "$0")" > /dev/null 2>&1 || return + pwd -P +)" + +# shellcheck source=helper_functions.sh +. "${LINTDIR}/helper_functions.sh" +# Exit if the code isn't in a git repo +if [ "${IN_GIT_TREE}" -eq 0 ]; then + exit 0 +fi + +# Check for duplicated <device/pci_{def,type}.h> +DUPLICATED="grep '<device/pci_(def|type).h>' $(grep -l '<device/pci.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <device/pci.h> is supposed to provide <device/pci_{def,type}.h>" +fi + +# Check for duplicated <commonlib/bsd/cb_err.h>, <limits.h>, <stdbool.h>, <stdint.h> and <stddef.h> +DUPLICATED="grep '<commonlib/bsd/cb_err.h>|<limits.h>|<stdbool.h>|<stdint.h>|<stddef.h>' $(grep -l '<types.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <types.h> is supposed to provide <commonlib/bsd/cb_err.h>, <limits.h>, <stdbool.h>, <stdint.h> and <stddef.h>" +fi + +# Check for duplicated <stdarg.h> and <stdio.h> +DUPLICATED="grep '<stdarg.h>|<stdio.h>' $(grep -l '<string.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <string.h> is supposed to provide <stdarg.h> and <stdio.h>" +fi + +# Check for duplicated <arch/cpuid.h> +DUPLICATED="grep '<arch/cpuid.h>' $(grep -l '<arch/cpu.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <arch/cpu.h> is supposed to provide <arch/cpuid.h>" +fi + +# Check for duplicated <commonlib/bsd/cbmem_id.h> +DUPLICATED="grep '<commonlib/bsd/cbmem_id.h>' $(grep -l '<cbmem.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <cbmem.h> is supposed to provide <commonlib/bsd/cbmem_id.h>" +fi + +# Check for duplicated <commonlib/loglevel.h> +DUPLICATED="grep '<commonlib/loglevel.h>' $(grep -l '<console/console.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <console/console.h> is supposed to provide <commonlib/loglevel.h>" +fi + +# Check for duplicated <arch/cpu.h> +DUPLICATED="grep '<arch/cpu.h>' $(grep -l '<cpu/cpu.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <cpu/cpu.h> is supposed to provide <arch/cpu.h>" +fi + +# Check for duplicated <cpu/x86/msr_access.h> +DUPLICATED="grep '<cpu/x86/msr_access.h>' $(grep -l '<cpu/x86/msr.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <cpu/x86/msr.h> is supposed to provide <cpu/x86/msr_access.h>" +fi + +# Check for duplicated <arch/mmio.h> +DUPLICATED="grep '<arch/mmio.h>' $(grep -l '<device/mmio.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <device/mmio.h> is supposed to provide <arch/mmio.h>" +fi + +# Check for duplicated <arch/pci_ops.h> +DUPLICATED="grep '<arch/pci_ops.h>' $(grep -l '<device/pci_ops.h>')" +if [ -n "${DUPLICATED}" ]; then + echo "Warning: <device/pci_ops.h> is supposed to provide <arch/pci_ops.h>" +fi